PHP 7.3 #22
PHP 7.3 #22
Conversation
|
Thanks for the pull request!! To ensure quality review, Couchbase employs a code review system based on Gerrit to manage the workflow of changes in addition to tracking our contributor agreements. To get this change in and collaborate in code review, please register on Gerrit and accept our CLA. The easiest way to do this is to follow the link below, sign in with your GitHub account and then follow through the steps provided on that page to sign an 'Individual' agreement: http://review.couchbase.org/#/settings/new-agreement. Keep in mind that the emails we are seeing on the commits are: Note: Please contact us if you have any issues registering with Gerrit! If you have not signed our CLA within 7 days, the Pull Request will be automatically closed. ::SDKBOT/PR:no_cla |
|
CLA already signed.... |
|
Thanks, @remicollet. I will import that through gerrit. |
|
BTW: confirmed that this works in Windows as well. |
|
thanks @Jan-E |
4 participants
1st commit is for internals changes:
see https://github.com/php/php-src/blob/master/UPGRADING.INTERNALS
2nd commit -WFormat warning nicely raised when building with 7.3 (don't know why previous don't catch these... )